Skip to content

Feature: Add a tooltip to the runs table experiment name column #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

rileyajones
Copy link
Contributor

@rileyajones rileyajones commented Dec 8, 2022

Motivation for features / changes

For Googlers b/259431435
We abbreviate the name of the experiment which can lead to confusion. By showing the full name in a tooltip we provide users a way of accessing that information.

Technical description of changes

Tooltips are generally created by setting the title attribute. However, this particular column is a custom element and thus required me to pass the attribute through.

Screenshots of UI changes

IDK how to screenshot tooltips 🤷

Detailed steps to verify changes work correctly (as executed by you)

I tested this on internal tensorboard where the experiment column gets used.

Copy link
Contributor

@JamesHollyer JamesHollyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can screenshot tooltips with Macs using the cmd+shift+4 hotkey. Not sure about linux. However, I do not think it is necessary.

@rileyajones rileyajones merged commit 1e0426d into tensorflow:master Dec 12, 2022
qihach64 pushed a commit to qihach64/tensorboard that referenced this pull request Dec 19, 2022
…orflow#6097)

## Motivation for features / changes
For Googlers b/259431435
We abbreviate the name of the experiment which can lead to confusion. By
showing the full name in a tooltip we provide users a way of accessing
that information.

## Technical description of changes
Tooltips are generally created by setting the `title` attribute.
However, this particular column is a custom element and thus required me
to pass the attribute through.

## Screenshots of UI changes
IDK how to screenshot tooltips 🤷 

## Detailed steps to verify changes work correctly (as executed by you)
I tested this on internal tensorboard where the experiment column gets
used.
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
…orflow#6097)

## Motivation for features / changes
For Googlers b/259431435
We abbreviate the name of the experiment which can lead to confusion. By
showing the full name in a tooltip we provide users a way of accessing
that information.

## Technical description of changes
Tooltips are generally created by setting the `title` attribute.
However, this particular column is a custom element and thus required me
to pass the attribute through.

## Screenshots of UI changes
IDK how to screenshot tooltips 🤷 

## Detailed steps to verify changes work correctly (as executed by you)
I tested this on internal tensorboard where the experiment column gets
used.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
…orflow#6097)

## Motivation for features / changes
For Googlers b/259431435
We abbreviate the name of the experiment which can lead to confusion. By
showing the full name in a tooltip we provide users a way of accessing
that information.

## Technical description of changes
Tooltips are generally created by setting the `title` attribute.
However, this particular column is a custom element and thus required me
to pass the attribute through.

## Screenshots of UI changes
IDK how to screenshot tooltips 🤷 

## Detailed steps to verify changes work correctly (as executed by you)
I tested this on internal tensorboard where the experiment column gets
used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants